-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use faster Python unicode API for unquoter #1292
Conversation
CodSpeed Performance ReportMerging #1292 will improve performances by 8.19%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1292 +/- ##
=======================================
Coverage 95.85% 95.85%
=======================================
Files 27 27
Lines 5261 5263 +2
Branches 311 311
=======================================
+ Hits 5043 5045 +2
Misses 192 192
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We don't have any benchmarks for accessing the properties that need to go through the unquoter |
could be faster if no change as well |
Every character that was being iterated during unquote was calling
__Pyx_GetItemInt_Unicode
Its a bit faster to use
PyUnicode_READ
instead