Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of the URL.extend_query method #1305

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 17, 2024

Improve performance of extend_query

@bdraco bdraco force-pushed the extend_query_performance branch from 7c61fc5 to a86ad84 Compare October 17, 2024 20:15
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 17, 2024
@bdraco bdraco changed the title Improve performance of extend_query Improve performance of the URL.extend_query method Oct 17, 2024
Copy link

codspeed-hq bot commented Oct 17, 2024

CodSpeed Performance Report

Merging #1305 will improve performances by 43.76%

Comparing extend_query_performance (a86ad84) with master (fa83191)

Summary

⚡ 3 improvements
✅ 62 untouched benchmarks

Benchmarks breakdown

Benchmark master extend_query_performance Change
test_url_extend_query_existing_query_simple_query_dict 786.3 µs 686 µs +14.63%
test_url_extend_query_existing_query_string 333.6 µs 232.1 µs +43.76%
test_url_extend_query_simple_query_dict 759.4 µs 658.3 µs +15.36%

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (fa83191) to head (a86ad84).
Report is 146 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1305      +/-   ##
==========================================
- Coverage   95.90%   95.90%   -0.01%     
==========================================
  Files          27       27              
  Lines        5323     5322       -1     
  Branches      320      319       -1     
==========================================
- Hits         5105     5104       -1     
  Misses        192      192              
  Partials       26       26              
Flag Coverage Δ
CI-GHA 95.90% <100.00%> (-0.01%) ⬇️
MyPy 44.30% <85.71%> (-0.02%) ⬇️
OS-Linux 99.30% <100.00%> (-0.01%) ⬇️
OS-Windows 99.36% <100.00%> (-0.01%) ⬇️
OS-macOS 99.03% <100.00%> (-0.01%) ⬇️
Py-3.10.11 99.00% <100.00%> (-0.01%) ⬇️
Py-3.10.15 99.26% <100.00%> (-0.01%) ⬇️
Py-3.11.10 99.26% <100.00%> (-0.01%) ⬇️
Py-3.11.9 99.00% <100.00%> (-0.01%) ⬇️
Py-3.12.7 99.26% <100.00%> (-0.01%) ⬇️
Py-3.13.0 99.26% <100.00%> (-0.01%) ⬇️
Py-3.9.13 98.96% <100.00%> (-0.01%) ⬇️
Py-3.9.20 99.21% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 99.26% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.17 99.28% <100.00%> (-0.01%) ⬇️
VM-macos-latest 99.03% <100.00%> (-0.01%) ⬇️
VM-ubuntu-latest 99.30% <100.00%> (-0.01%) ⬇️
VM-windows-latest 99.36% <100.00%> (-0.01%) ⬇️
pytest 99.30% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review October 17, 2024 20:29
@bdraco bdraco merged commit fa4f43b into master Oct 17, 2024
43 of 46 checks passed
@bdraco bdraco deleted the extend_query_performance branch October 17, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant