Fix blocking I/O to load python code when the network location contains non-ascii characters #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1342 will improve performances by ×2.2Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1342 +/- ##
==========================================
+ Coverage 96.09% 96.13% +0.04%
==========================================
Files 27 27
Lines 5483 5541 +58
Branches 336 358 +22
==========================================
+ Hits 5269 5327 +58
Misses 188 188
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
changed the title
bdraco
changed the title
for more information, see https://pre-commit.ci
bdraco
changed the title
urlsplit to address performance issues
psf-chronographer
bot
added
the
bot:chronographer:provided
bdraco
changed the title
urlsplit to address performance issuesurlsplit to address performance issues
|
This is a performance improvement and a bugfix but there is no way to separate so bugfix wins for the changelog messages |
bdraco
changed the title
urlsplit to address performance issues
bdraco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlsplitis not async safe since it can importunicodedataat runtime which does blocking I/O to load python code from disk. This PR replaces it with a new version that is functionality compatible but rewritten a bit to have better performance and avoid run time importsTo improve performance #190 (comment) suggested cythonizing it but I think thats a lot more to maintain, and the performance issues can likely be solved in python.
Long term this also means we don't have to use
SplitResultinternally anymore and can fix issues whereurlsplitdoesn't work as we expected and have been sitting in the issue queue for years in future PRs