Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fast path to get_str_query for dict and str #1401

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 30, 2024

These are the most common types, and since we frequently call extend_query in aiohttp it makes sense to optimize for this case.

These are the most common types
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 30, 2024
@bdraco bdraco changed the title Add a fast path to get_str_query for dict and str Add a fast path to get_str_query for dict and str Oct 30, 2024
Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #1401 will improve performances by 24.56%

Comparing fast_path_for_dict_query (31cf85c) with master (8ce8d67)

Summary

⚡ 1 improvements
✅ 81 untouched benchmarks

Benchmarks breakdown

Benchmark master fast_path_for_dict_query Change
test_url_extend_query_existing_query_string 191.1 µs 153.4 µs +24.56%

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (8ce8d67) to head (31cf85c).
Report is 67 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1401   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files          31       31           
  Lines        5751     5753    +2     
  Branches      342      343    +1     
=======================================
+ Hits         5524     5526    +2     
  Misses        201      201           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 96.05% <100.00%> (+<0.01%) ⬆️
MyPy 48.84% <25.00%> (-0.02%) ⬇️
OS-Linux 99.55% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.61% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.30% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.46% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.52% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.55% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.30% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.55% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.61% <100.00%> (+<0.01%) ⬆️
pytest 99.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES/1401.misc.rst Outdated Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review October 30, 2024 18:50
@bdraco bdraco enabled auto-merge (squash) October 30, 2024 18:53
@bdraco bdraco merged commit 71d171e into master Oct 30, 2024
44 of 46 checks passed
@bdraco bdraco deleted the fast_path_for_dict_query branch October 30, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant