Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment version to 1.18.3.dev0 #1440

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Increment version to 1.18.3.dev0 #1440

merged 1 commit into from
Dec 1, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 29, 2024

PyPI uploads (not sure if its PyPI or GitHub) are experiencing issues at the moment as uploads are taking ~5x as much time as normal. Both 1.18.1 (hit the workflow timeout) and 1.18.2 (token expired before it finished) failed to upload.

I'll try doing the release again tomorrow. Based on the upload times on aiohappyeyeballs on Sat Nov 30th, I expect a release would still fail.

Tracking pypa/gh-action-pypi-publish#307

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Nov 29, 2024
Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #1440 will degrade performances by 18.7%

Comparing inc_ver_1183dev0 (98e0d6b) with master (65d3aed)

Summary

❌ 3 (👁 3) regressions
✅ 82 untouched benchmarks

Benchmarks breakdown

Benchmark master inc_ver_1183dev0 Change
👁 test_long_query 2 ms 2.2 ms -8.56%
👁 test_quote_long_path 1.7 ms 1.8 ms -8.52%
👁 test_quoter_quote_utf8 319.9 µs 393.5 µs -18.7%

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (65d3aed) to head (98e0d6b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1440   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          31       31           
  Lines        5876     5876           
  Branches      349      349           
=======================================
  Hits         5648     5648           
  Misses        202      202           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 96.11% <100.00%> (ø)
MyPy 49.42% <100.00%> (ø)
OS-Linux 99.55% <100.00%> (ø)
OS-Windows 99.62% <100.00%> (ø)
OS-macOS 99.30% <100.00%> (ø)
Py-3.10.11 99.28% <100.00%> (ø)
Py-3.10.15 99.51% <100.00%> (ø)
Py-3.11.10 99.51% <100.00%> (ø)
Py-3.11.9 99.28% <100.00%> (ø)
Py-3.12.7 99.51% <100.00%> (ø)
Py-3.13.0 99.51% <100.00%> (ø)
Py-3.9.13 99.24% <100.00%> (ø)
Py-3.9.20 99.47% <100.00%> (ø)
Py-pypy7.3.16 99.53% <100.00%> (ø)
Py-pypy7.3.17 99.55% <100.00%> (ø)
VM-macos-latest 99.30% <100.00%> (ø)
VM-ubuntu-latest 99.55% <100.00%> (ø)
VM-windows-latest 99.62% <100.00%> (ø)
pytest 99.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Dec 1, 2024

Looks like whatever was going on that caused uploads to be slow has been resolved since propcache published just fine.

I'm going to finish up whats in the pull queue and than do .3

@bdraco bdraco merged commit 4706c4c into master Dec 1, 2024
46 of 48 checks passed
@bdraco bdraco deleted the inc_ver_1183dev0 branch December 1, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant