Skip to content

Commit

Permalink
fix(AIP-164): add missing requirement for delete_time (#1425)
Browse files Browse the repository at this point in the history
  • Loading branch information
noahdietz authored Sep 25, 2024
1 parent fa38b8b commit b7bb0c3
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions aip/general/0164.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ mark the resource as having been deleted, but not completely remove it from the
system. If the method behaves this way, it **should** return the updated
resource instead of `google.protobuf.Empty`.

Resources that support soft delete **should** have a `purge_time` field as
described in AIP-148. Additionally, resources **should** include a `DELETED`
state value if the resource includes a `state` field (AIP-216).
Resources that support soft delete **should** have both a `delete_time` and
`purge_time` field as described in AIP-148. Additionally, resources **should**
include a `DELETED` state value if the resource includes a `state` field
(AIP-216).

### Undelete

Expand Down Expand Up @@ -147,6 +148,7 @@ resource is not deleted, the service **must** respond with `ALREADY_EXISTS`

## Changelog

- **2024-09-24**: Included missing requirement for `delete_time`.
- **2023-07-13**: Renamed overloaded `expire_time` to `purge_time`.
- **2021-07-12**: Added error behavior when soft deleting a deleted resource.
- **2021-07-12**: Clarified that `ALREADY_EXISTS` errors apply to `Undelete`.
Expand Down

0 comments on commit b7bb0c3

Please sign in to comment.