Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Extra Logs for Config Reading Behaviour #517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matheusgomes28
Copy link

Improves the logs for #516 . After looking into the codebase, I understand that the following behaviour is intended:

  1. read .air.toml if available.
  2. failing above, read .air.conf if available.
  3. failing above, use default configs.

The issue is that the user currently has no idea if they simply run air from their repo, with an invalid .air.toml. It is 100% clearer to log the behaviour so the user doesn't waste time (like I did) wondering why my .air.toml settings weren't picked up !

@matheusgomes28
Copy link
Author

Is air still under development? I can close PR if you guys aren't taking any more features

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56d3d58) 69.22% compared to head (50daf32) 69.66%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
+ Coverage   69.22%   69.66%   +0.44%     
==========================================
  Files           9        9              
  Lines        1082     1088       +6     
==========================================
+ Hits          749      758       +9     
+ Misses        253      251       -2     
+ Partials       80       79       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosmtrek
Copy link
Collaborator

cosmtrek commented Feb 1, 2024

@matheusgomes28 Thanks for your PR. Air is indeed still being maintained, though it is currently not in a phase of active development. We will periodically address issues and pull requests in batches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants