Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial CI setup #19

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Add initial CI setup #19

merged 2 commits into from
Feb 7, 2020

Conversation

adithyaselv
Copy link
Contributor

@adithyaselv adithyaselv commented Feb 7, 2020

Fixes #15 depends on #13

In this PR I am adding a basic CI setup using travis which will build and test the API gateway written in Scala.

Definition of done

  • Add .travis.yml file with required config
  • Add rule to merge only if the build passes

Future work (create issues)

@adithyaselv
Copy link
Contributor Author

@rasmitha-koduru @shubhangis91 Basic CI is working now ! yay. You guys might want to learn about multi-project builds in order to add your own scripts

@@ -0,0 +1,6 @@
language: scala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the negative case u added to test CI?

Copy link
Contributor Author

@adithyaselv adithyaselv Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The green check mark next to the commit id indicates CI passed for the commit . It failed for the first commit since the api-gateway service wasn't there in the master then

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok got it, yes i have seen the build report. Thanks

@rasmitha-koduru rasmitha-koduru requested review from rasmitha-koduru and removed request for rasmitha-koduru February 7, 2020 03:24
@rasmitha-koduru rasmitha-koduru merged commit a80678d into master Feb 7, 2020
@adithyaselv adithyaselv deleted the feature/setup-ci branch February 7, 2020 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Travis CI to protect builds
2 participants