Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async-to-promises Babel plugin #2

Closed
wants to merge 1 commit into from
Closed

Conversation

lencioni
Copy link
Contributor

This plugin claims to enable async/await without generators.

https://github.com/marten-de-vries/kneden

This plugin claims to enable async/await without generators.

https://github.com/marten-de-vries/kneden
@goatslacker
Copy link
Collaborator

We should look out for these cases babel/kneden#13

"babel-plugin-transform-es2015-template-literals": "^6.5.0",
"babel-plugin-transform-es3-member-expression-literals": "^6.5.0",
"babel-plugin-transform-es3-property-literals": "^6.5.0",
"babel-plugin-transform-jscript": "^6.5.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc the order of these is important - they should not be alphabetized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done automatically by npm install. Why would the order of the dependencies in the package.json file affect anything?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nvm, I though this was the Babel config. Don't mind me :-)

@ljharb
Copy link
Collaborator

ljharb commented Apr 21, 2016

The change looks good, but I don't think we're ready to put this transform in the preset until we've tested it out a bit and it handles a few more cases.

@lencioni
Copy link
Contributor Author

Cool cool cool, makes sense.

@ljharb
Copy link
Collaborator

ljharb commented Nov 9, 2016

To clarify - for us to be able to use async/await, we need a transform (any transform) that either a) transforms 100% of the spec, or b) can be combined with a linter rule that fully forbids the parts of the spec that it can't transpile.

@lencioni
Copy link
Contributor Author

I don't plan on working on this any time soon. Some brave soul should feel free to resurrect.

@lencioni lencioni closed this Mar 22, 2017
@lencioni lencioni deleted the async-to-promises branch March 22, 2017 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants