-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async-to-promises Babel plugin #2
Conversation
This plugin claims to enable async/await without generators. https://github.com/marten-de-vries/kneden
We should look out for these cases babel/kneden#13 |
"babel-plugin-transform-es2015-template-literals": "^6.5.0", | ||
"babel-plugin-transform-es3-member-expression-literals": "^6.5.0", | ||
"babel-plugin-transform-es3-property-literals": "^6.5.0", | ||
"babel-plugin-transform-jscript": "^6.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc the order of these is important - they should not be alphabetized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done automatically by npm install
. Why would the order of the dependencies in the package.json file affect anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nvm, I though this was the Babel config. Don't mind me :-)
The change looks good, but I don't think we're ready to put this transform in the preset until we've tested it out a bit and it handles a few more cases. |
Cool cool cool, makes sense. |
To clarify - for us to be able to use async/await, we need a transform (any transform) that either a) transforms 100% of the spec, or b) can be combined with a linter rule that fully forbids the parts of the spec that it can't transpile. |
I don't plan on working on this any time soon. Some brave soul should feel free to resurrect. |
This plugin claims to enable async/await without generators.
https://github.com/marten-de-vries/kneden