Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect ksp symbol validation #1323

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Remove incorrect ksp symbol validation #1323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 5.1.1
Remove incorrect ksp symbol validation in processing of @EpoxyModelClass

# 5.1.0
Updates Kotlin to 1.7.20 and KSP to 1.7.20-1.0.7, as well as the room compiler processing (xprocessing) library to 2.5.0-beta01.

Expand Down
13 changes: 0 additions & 13 deletions epoxy-processor/src/main/java/com/airbnb/epoxy/processor/EpoxyProcessor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,19 +95,6 @@ class EpoxyProcessor @JvmOverloads constructor(
}
timer.markStepCompleted("build target class models")

if (isKsp()) {
modelClassMap.values
.filterIsInstance<BasicGeneratedModelInfo>()
.mapNotNull { it.boundObjectTypeElement }
.filter { !it.validate() }
.let { invalidModelTypes ->
timer.markStepCompleted("validate symbols")
if (invalidModelTypes.isNotEmpty()) {
return invalidModelTypes
}
}
}

addAttributesFromOtherModules(modelClassMap, memoizer)
timer.markStepCompleted("add attributes from other modules")

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
VERSION_NAME=5.1.0
VERSION_NAME=5.1.1
GROUP=com.airbnb.android
POM_DESCRIPTION=Epoxy is a system for composing complex screens with a ReyclerView in Android.
POM_URL=https://github.com/airbnb/epoxy
Expand Down