Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSX is not displayed correctly in webpage #2301

Open
aromalanil opened this issue Oct 4, 2020 · 13 comments · May be fixed by #2451
Open

JSX is not displayed correctly in webpage #2301

aromalanil opened this issue Oct 4, 2020 · 13 comments · May be fixed by #2451
Labels
editorial pull request wanted react

Comments

@aromalanil
Copy link

aromalanil commented Oct 4, 2020 •
edited
Loading

Description

  • The JSX example is not correctly displayed in the webpage, there is no problem with the Readme file though

Screenshot

image

Reason

I think the markdown to HTML convertor is what causing the issue
@aromalanil
Copy link
Author

Here is the Readme Link: https://github.com/airbnb/javascript/blob/master/react/README.md#quotes

@xrkffgg xrkffgg mentioned this issue Jan 8, 2021
Closed
@khareyash05

This comment has been minimized.

Sign in to view
@ljharb

This comment has been minimized.

Sign in to view
@itsjeremyrivera

This comment has been minimized.

Sign in to view
@Blkwidows22

This comment has been minimized.

Sign in to view
@ram170
Copy link

ram170 commented Mar 10, 2021

This issue seems to be similar to:
jekyll/jekyll#6191
class="err" is added while converting markdown to html for the particular JSX block. Issue seems to be with GitHub's automatic page generator.

rahulrk-dev added a commit to rahulrk-dev/javascript that referenced this issue Jul 11, 2021
@rahulrk-dev
Update react/README.md
6daa866 
Fix jsx syntax display issue in webpage

Fixes airbnb#2301
rahulrk-dev added a commit to rahulrk-dev/javascript that referenced this issue Jul 11, 2021
@rahulrk-dev
Update react/README.md
a684a66 
Fix jsx display issue in webpage
https://airbnb.io/javascript/react/#quotes

Fixes airbnb#2301
@rahulrk-dev rahulrk-dev linked a pull request Jul 11, 2021 that will close this issue
Draft
This was referenced Jul 14, 2022
Draft
Draft
Merged
fazil-shaik pushed a commit to fazil-shaik/javascript that referenced this issue Oct 20, 2023
fix airbnb#2301 web page Display error in jsx
73dc208
@JatinSainiOO7

This comment was marked as spam.

Sign in to view
@itsjeremyrivera

This comment was marked as spam.

Sign in to view
@Robbie-BOIII

This comment was marked as spam.

Sign in to view
@Robbie-BOIII Robbie-BOIII mentioned this issue Oct 11, 2024
Open
@DetrojaRadhey
Copy link

I'm interested in working on this issue. Could you please confirm if it's still open?

@ljharb
Copy link
Collaborator

ljharb commented Nov 9, 2024

@DetrojaRadhey you can see at the top of the issue that it's open, but you can also see that #2451 may fix it. Thus, if you have a contribution, please comment with a branch link on #2451, and I can pull it into the existing PR.

@DetrojaRadhey
Copy link

@ljharb, I have used HTML character entities to display JSX code in a markdown format without being rendered as HTML.

Review this PR and let me know if any changes needed:
#3060

@ljharb
Copy link
Collaborator

ljharb commented Nov 11, 2024

@DetrojaRadhey i did that, yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editorial pull request wanted react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update react/README.md rahulrk-dev/javascript
10 participants
@ljharb @ram170 @aromalanil @khareyash05 @itsjeremyrivera @Blkwidows22 @DetrojaRadhey @JatinSainiOO7 @Robbie-BOIII and others