Update import/no-extraneous-dependencies to alow test files
#1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now allows devDependencies in all files called `test.js`, `spec.js`, `*.test.js` or `*.spec.js`
|
Thanks :-) I already have this change locally, but it's blocked on import-js/eslint-plugin-import#602 |
|
|
|
@ljharb Would you consider |
|
@stevemao a PR that adds that seems just fine. |
stevemao
added a commit
to stevemao/javascript
that referenced
this pull request
Feb 23, 2017
ljharb
pushed a commit
to stevemao/javascript
that referenced
this pull request
Feb 23, 2017
ivanzusko
pushed a commit
to ivanzusko/javascript
that referenced
this pull request
Mar 1, 2017
ivanzusko
pushed a commit
to ivanzusko/javascript
that referenced
this pull request
Mar 1, 2017
ivanzusko
pushed a commit
to ivanzusko/javascript
that referenced
this pull request
Mar 1, 2017
xalexec
pushed a commit
to xalexec/javascript
that referenced
this pull request
Mar 26, 2017
jaylaw81
pushed a commit
to appirio-digital/ads-best-practices
that referenced
this pull request
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now allows devDependencies in all files called
test.js,spec.js,*.test.jsor*.spec.js