Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eslint config][base][patch] enable option allowImplicit in rule array-callback-return #1668

Merged
merged 1 commit into from
Dec 24, 2017
Merged

[eslint config][base][patch] enable option allowImplicit in rule array-callback-return #1668

merged 1 commit into from
Dec 24, 2017
+1 −1

Conversation

1pete
Copy link
Contributor

@1pete 1pete commented Dec 24, 2017

This allows return undefined implicitly.

array.map((item) => {
  return;
});

@ljharb
Copy link
Collaborator

ljharb commented Dec 24, 2017

Linking to eslint/eslint#8539 / eslint/eslint#9344

ljharb
ljharb approved these changes Dec 24, 2017
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit 90235ca into airbnb:master Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-patch: loosen/fix/document rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1pete @ljharb