Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint config] [deps] update eslint-plugin-react-hooks #3068

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

ptmkenny
Copy link
Contributor

@ptmkenny ptmkenny commented Dec 7, 2024

eslint-plugin-react-hooks had a new major version a couple months ago.

This new version has several new useful checks, so it would be great if the config could be updated to use this version.

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll also need to change the peer deps entry.

@ptmkenny
Copy link
Contributor Author

ptmkenny commented Dec 7, 2024

Thanks for the quick feedback! I updated the peer dependency.

@ljharb ljharb force-pushed the eslint-plugin-react-hooks branch from cae80ba to 11f986f Compare December 9, 2024 06:50
@ljharb ljharb changed the title Update to new major version of eslint-plugin-react-hooks [eslint config] [deps] update eslint-plugin-react-hooks Dec 9, 2024
@ljharb ljharb merged commit 11f986f into airbnb:master Dec 9, 2024
51 checks passed
@renchris
Copy link

How do we use this? The current release version is 19.0.4 from Dec 25, 2021.

@ljharb
Copy link
Collaborator

ljharb commented Dec 11, 2024

@renchris you don't use it, until it's released, which it's not yet (it was only merged 2 days ago)

@renchris
Copy link

With the current and last package release being a few years ago, what is a rough timeframe expectation for the next release containing this update to be?

@ljharb
Copy link
Collaborator

ljharb commented Dec 11, 2024

There's no expected timeframe and no release schedule, and the time since the last release has no bearing on anything - no release has been needed since the last one, and the next one will include full eslint 9 support. feel free to follow #2961 for updates.

@ptmkenny
Copy link
Contributor Author

@renchris If you want to use this now, if you're using npm, you can install eslint-plugin-react-hooks 5 with --force. That will override the v4 specified by the current release.

@renchris
Copy link

Thank you, you two. I will override the peer dependency eslint-plugin-react-hooks version 5 with --force now and follow the #2961 thread for the next eslint v9 version with this update as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants