Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react] inline export syntax #491

Merged
merged 1 commit into from
Sep 16, 2015

Conversation

gilbox
Copy link
Contributor

@gilbox gilbox commented Aug 28, 2015

b more 1337

@justjake
Copy link
Collaborator

LGTM, but this may be controversial with the original guide authors? Some people complained about having exports other than at the very bottom of the file.

@ljharb
Copy link
Collaborator

ljharb commented Aug 28, 2015

In this specific case, I like this change, because 100% of the code below the default export is something that will be moved into inline static properties at some point. In all other cases, I'd want the exports to be the final thing in any file. However, I'm not sure if the inconsistency is clearly explained.

@gilbox
Copy link
Contributor Author

gilbox commented Aug 28, 2015

If the goal is to place all exports at the bottom, then at least one code example needs to be updated.

@goatslacker
Copy link
Collaborator

yeah sure

@ljharb
Copy link
Collaborator

ljharb commented Aug 28, 2015

(I opened #492 to fix that code example)

@justjake
Copy link
Collaborator

I'm merging this because I agree and discussion stopped.

justjake added a commit that referenced this pull request Sep 16, 2015
@justjake justjake merged commit c42275f into airbnb:master Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants