Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eslint's jsx-quotes in favor of the deprecated react/jsx-quotes rule #521

Closed
wants to merge 1 commit into from
Closed

Use eslint's jsx-quotes in favor of the deprecated react/jsx-quotes rule #521

wants to merge 1 commit into from

Conversation

janraasch
Copy link

Had to update eslint and babel-eslint to get npm test to pass.

See jsx-eslint/eslint-plugin-react#217

By the way, an easy way to get rid of the deprecation warning for the time being is simply to add

    "jsx-quotes": [
      2, "prefer-double"
    ],
    "react/jsx-quotes": 0

to ones local .eslintrc file.

Had to update eslint and babel-eslint to get `npm test` to pass.
@janraasch
Copy link
Author

Whoops, just saw that this duplicates #518 and #514. But this also includes a passing test suite :). Of course, feel free to close this, if you are inclined to do so. And if so, sorry for the noise...

@justjake
Copy link
Collaborator

Hopefully 0.1.0 resolved this! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants