Clarify proper type casting for Numbers #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -1640,7 +1640,7 @@ Other Style Guides | |||
| const totalScore = String(this.reviewScore); | |||
| ``` | |||
|
|
|||
| - [21.3](#21.3) <a name='21.3'></a> Use `parseInt` for Numbers and always with a radix for type casting. | |||
| - [21.3](#21.3) <a name='21.3'></a> Numbers: Use `Number` for type casting and `parseInt` with a radix for parsing. | |||
There was a problem hiding this comment.
could this say parsing strings, and also continue to say always with a radix?
Clarifies when to use `Number` vs. `parseInt` for Number type casting. Fixes: #523
|
👍 this LGTM |
ljharb
added a commit
that referenced
this pull request
Sep 25, 2015
Clarify proper type casting for Numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies when to use
Numbervs.parseIntfor Number type casting, encouraging the proper usage of both.Fixes: #523
Previously, at item 21.3, the guide read:
However, the example displays:
Issue: It is unclear whether
Numberis acceptable because the guide only directly states to useparseIntdespite the example forNumber. Indeed,NumberandparseIntare not interchangeable and should both be used properply.