[Compose] Add merge paths flag #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag is set to false by default to align with LottieAnimationView. Added some documentation too
jossiwolf
force-pushed
the
jw/merge-paths-flag
branch
from
68f690d
to
3987b8e
Compare
gpeal
reviewed
Feb 20, 2021
lottie-compose/src/main/java/com/airbnb/lottie/compose/LottieAnimationState.kt
Outdated
Show resolved
Hide resolved
lottie-compose/src/main/java/com/airbnb/lottie/compose/LottieAnimation.kt
Outdated
Show resolved
Hide resolved
With this, we won't trigger a whole recomposition for these state changes
|
@gpeal I added a toggle for merge paths to the Compose sample. Let me know if you want to have that as part of this PR. lottie-compose-merge-paths-toggle-sample.mp4 |
gpeal
reviewed
Feb 21, 2021
lottie-compose/src/main/java/com/airbnb/lottie/compose/LottieAnimation.kt
Outdated
Show resolved
Hide resolved
lottie-compose/src/main/java/com/airbnb/lottie/compose/LottieAnimationState.kt
Outdated
Show resolved
Hide resolved
lottie-compose/src/main/java/com/airbnb/lottie/compose/LottieAnimationState.kt
Outdated
Show resolved
Hide resolved
jossiwolf
force-pushed
the
jw/merge-paths-flag
branch
from
e364984
to
4b8a5d1
Compare
|
Awesome, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #1734
LottieAnimationViewhad merge paths disabled by default, butLottieAnimationenables them by default. As long as merge paths contain known bugs, I think it makes sense not to change that behavior - what do you think?I added a flag for it to the state. If you want, we can add it as a constructor param too, but I feel like that's not needed as it's not that commonly used.
Cheers