Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Compose] Parse LottieComposition synchronously instead of using LottieTask" #1890

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Revert "[Compose] Parse LottieComposition synchronously instead of using LottieTask" #1890

merged 1 commit into from
Sep 8, 2021

Conversation

gpeal
Copy link
Collaborator

@gpeal gpeal commented Sep 8, 2021

Reverts #1888

This was not a good solution. It lost task joining so requesting the same animation multiples would parse the animation multiple times.

@gpeal gpeal mentioned this pull request Sep 8, 2021
Merged
@LottieSnapshotBot
Copy link

Snapshot Tests
28: Report Diff

@gpeal gpeal merged commit 8947be8 into master Sep 8, 2021
@gpeal gpeal deleted the revert-1888-gpeal/init-perf branch September 8, 2021 03:19
gpeal added a commit that referenced this pull request Sep 8, 2021
@gpeal
[Compose] Warm the task cache before LaunchedEffect runs (#1891)
ac17e0f 
This builds on the revert in #1890 and leverages the task joining behavior of LottieCompositionFactory to synchronously initiate the task when the composition first runs so that it can then be joined to immediately retrieved whenever the LaunchedEffect runs.

Fixes #1880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpeal @LottieSnapshotBot