Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compose] Respect system animator scale #2000

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Conversation

gpeal
Copy link
Collaborator

@gpeal gpeal commented Jan 17, 2022

This will only automatically work for animateLottieCompositionAsState(...) because accessing the system animator scale requires a Context and the coroutines LottieAnimatable functions don't have access to that. Apps will need to manually handle the scale if they aren't using animateLottieCompositionAsState(...).

When animations are disabled, the speed becomes infinite and Lottie will jump to the end of the animation.

Fixes #1906

@gpeal gpeal force-pushed the gpeal/compose-system-animations branch from 7b5ac1f to 387d104 Compare January 17, 2022 04:09
@LottieSnapshotBot
Copy link

Snapshot Tests
28: Report Diff

@gpeal gpeal merged commit a226747 into master Jan 17, 2022
@gpeal gpeal deleted the gpeal/compose-system-animations branch January 17, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lottie Compose does not honor accessibility setting to not play animations.
2 participants