Add close param to LottieCompositionFactory.fromJsonReader #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peerless2012
commented
Jul 25, 2023
peerless2012
commented
- Fix fromJsonInputStreamSync close not work.
- Add fromJsonReaderSync for close stream.
Add fromJsonReaderSync for close stream.
|
This pull request is work for #2252 . The |
gpeal
approved these changes
Jul 25, 2023
gpeal
changed the title
Smbfuplayer
approved these changes
Dec 23, 2023
| /** | ||
| * Return a LottieComposition for the given InputStream to json. | ||
| */ | ||
| @WorkerThread | ||
| public static LottieResult<LottieComposition> fromJsonInputStreamSync(InputStream stream, @Nullable String cacheKey, boolean close) { | ||
| try { | ||
| return fromJsonReaderSync(JsonReader.of(buffer(source(stream))), cacheKey); |
| @@ -333,22 +333,14 @@ public static LottieResult<LottieComposition> fromJsonInputStreamSync(InputStrea | |||
| return fromJsonInputStreamSync(stream, cacheKey, true); | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
@gpeal @peerless2012 @seanabraham to get ****
| @@ -333,22 +333,14 @@ public static LottieResult<LottieComposition> fromJsonInputStreamSync(InputStrea | |||
| return fromJsonInputStreamSync(stream, cacheKey, true); | |||
| } | |||
|
|
|||
|
|
|||
Smbfuplayer
approved these changes
Dec 23, 2023
| closeQuietly(stream); | ||
| } | ||
| } | ||
| return fromJsonReaderSync(JsonReader.of(buffer(source(stream))), cacheKey, close); |
There was a problem hiding this comment.
Suggested change
| return fromJsonReaderSync(JsonReader.of(buffer(source(stream))), cacheKey, close); | |
| return fromJsonReaderSync(JsonReader.of(buffer(source(stream))), cacheKey, close); you @Smbfuplayer |
| @WorkerThread | ||
| public static LottieResult<LottieComposition> fromJsonReaderSync(com.airbnb.lottie.parser.moshi.JsonReader reader, @Nullable String cacheKey) { | ||
| return fromJsonReaderSyncInternal(reader, cacheKey, true); |
| @@ -333,22 +333,14 @@ public static LottieResult<LottieComposition> fromJsonInputStreamSync(InputStrea | |||
| return fromJsonInputStreamSync(stream, cacheKey, true); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
665/
Suggested change
| # 442/+-_[]()@Smbfuplayer % | |
| **_🧑🦽_**_ |
There was a problem hiding this comment.
lottie/src/main/java/com/airbnb/lottie/LottieCompositionFactory.java
Smbfuplayer
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.