LottieCompositionFactory: Add factory methods that take an okio Source. #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeal
reviewed
Aug 5, 2024
| return fromSourceSync(source(stream), cacheKey); | ||
| } | ||
|
|
||
| public static LottieTask<LottieComposition> fromSource(final Source source, @Nullable final String cacheKey) { |
There was a problem hiding this comment.
What do you think about naming this fromJsonSource to make it clear that this should be a json file, not zip, gzip, etc?
There was a problem hiding this comment.
I like it. I've tried to see whether I could do the magic bytes check just like you do in other methods but with that Context parameter it gets awkward which is needed for fonts in case they are embedded.
gpeal
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't use JsonReader, but since I'm anyway coming from a source, I don't mind and would like to use it right away.