[a11y] Adding reduce motion logic to LottieAnimation for compose usage #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding reduce motion logic to LottieAnimation for compose usage
gpeal
reviewed
Aug 29, 2024
Comment on lines
136
to
137
| if (!drawable.animationsEnabled(context) && drawable.markerForAnimationsDisabled != null) { | ||
| drawable.progress = drawable.markerForAnimationsDisabled!!.startFrame |
There was a problem hiding this comment.
Suggested change
| if (!drawable.animationsEnabled(context) && drawable.markerForAnimationsDisabled != null) { | |
| drawable.progress = drawable.markerForAnimationsDisabled!!.startFrame | |
| val markerForAnimationsDisabled = drawable.markerForAnimationsDisabled | |
| if (!drawable.animationsEnabled(context) && markerForAnimationsDisabled != null) { | |
| drawable.progress = markerForAnimationsDisabled.startFrame |
Let's avoid !! here with a smart cast
| @@ -853,7 +853,7 @@ public void playAnimation() { | |||
| * | |||
| * @return The first non-null marker from the list of allowed reduced motion markers, or null if no such marker is found. | |||
| */ | |||
| private Marker getMarkerForAnimationsDisabled() { | |||
| public Marker getMarkerForAnimationsDisabled() { | |||
There was a problem hiding this comment.
Can you add a @RestrictTo(Library) on this one?
@RestrictTo(RestrictTo.Scope.LIBRARY)
gpeal
approved these changes
Aug 30, 2024
|
@gpeal thanks for merging, when you get time can you cut a . release with this change. |
|
yes, i saw this error for compose code but didn't realize it is happening for non compose, let me check and put a fix |
|
@pranayairan I just released 6.5.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our changes in #2536 didn't work for
LottieAnimationin compose. While LottieAnimation does use LottieDrawable, it has it's own animator and draws on canvas directly.This PR addresses that issue by making some logic of reduce motion readable outside LottieDrawable and consuming that logic in
LottieAnimationI tested this by adding a sample lottie file with reduce motion marker locally, see the attached video.
Screen_recording_20240829_125041.mp4