Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3.1.4 #1069

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Update to 3.1.4 #1069

merged 1 commit into from
Nov 4, 2019

Conversation

thedrick
Copy link
Contributor

@thedrick thedrick commented Nov 1, 2019

This updates the version to 3.1.4. I'm also hoping there's some change that was made recently that will fix the crash people are seeing 🙏

@thedrick thedrick requested a review from buba447 November 1, 2019 22:18
@buba447
Copy link
Collaborator

buba447 commented Nov 2, 2019

We should wait until the current pending pull requests are reviewed and merged. Im back from my honeymoon today so I will go through them tomo and check it all out.

Hold off on merging this.

@buba447
Copy link
Collaborator

buba447 commented Nov 4, 2019

Alright @thedrick im going to merge this and publish the release. Just a heads up this crash will not be fixed by this release. The crash is caused by a bug with swift packaging manager and there is currently an open bug filed for it with Apple here. There is a workaround by setting a build flag.
The bug only happens when importing lottie (or any swift package that uses generics) using swift packaging manager.

Cheers!

@buba447 buba447 merged commit 0525545 into master Nov 4, 2019
@buba447 buba447 deleted the thedrick-3.1.4 branch November 25, 2019 16:47
calda pushed a commit that referenced this pull request Nov 28, 2022
calda pushed a commit that referenced this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants