Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(Tooltip): Add onClose prop #355

Merged
merged 3 commits into from
Apr 20, 2020
Merged

new(Tooltip): Add onClose prop #355

merged 3 commits into from
Apr 20, 2020

Conversation

apiel51
Copy link
Collaborator

@apiel51 apiel51 commented Apr 10, 2020

to: @milesj @stefhatcher @hayes @alecklandgraf

Description

Adding an onClose prop to Tooltip that will fire a callback when the tooltip is closed.

Motivation and Context

Looking to color an Icon button differently depending on whether the tooltip is open or closed.

Testing

Locally

Screenshots

onclosetooltip

Checklist

  • My code follows the style guide of this project.
  • I have updated or added documentation accordingly.
  • I have read the CONTRIBUTING document.

@airbnb-bot
Copy link
Collaborator

airbnb-bot commented Apr 10, 2020

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
core +0.0% 549.55 KB 549.48 KB 689.07 KB 688.99 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 562671,
    "lib": 705524
  },
  "forms": {
    "esm": 35672,
    "lib": 47577
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Current

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 562737,
    "lib": 705605
  },
  "forms": {
    "esm": 35672,
    "lib": 47577
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

@stefhatcher stefhatcher changed the title update(Tooltip): Add onClose prop new(Tooltip): Add onClose prop Apr 20, 2020
@milesj
Copy link
Contributor

milesj commented Apr 20, 2020

Can you add a test?

@apiel51 apiel51 merged commit 3eab555 into master Apr 20, 2020
@apiel51 apiel51 deleted the apiel--tooltip-onclose branch April 20, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants