Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(Modal): Add topBar and topBarCentered support. #359

Merged
merged 2 commits into from
Apr 21, 2020

Conversation

stefhatcher
Copy link
Contributor

to: @milesj @stefhatcher @hayes @alecklandgraf

Description

new top bar request from design. can put whatever in it! has a border on the bottom with an option to center align (through text-align) the content. works independent of title/subtitle/header.

Motivation and Context

design needs

Testing

storybook

Screenshots

Core : Modal - With top bar , not centered ⋅ Storybook 2020-04-20 15-24-16

Core : Modal - With top bar , centered ⋅ Storybook 2020-04-20 15-25-02

Core : Modal - With top bar , topBarCentered , footer , and scrollable ⋅ Storybook 2020-04-20 15-25-35

Core : Modal - With top bar , title , footer , and scrollable ⋅ Storybook 2020-04-20 15-26-23

Checklist

  • My code follows the style guide of this project.
  • I have updated or added documentation accordingly.
  • I have read the CONTRIBUTING document.

@airbnb-bot
Copy link
Collaborator

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
core +0.2% 550.44 KB 549.56 KB 690.06 KB 689.08 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 562749,
    "lib": 705617
  },
  "forms": {
    "esm": 35672,
    "lib": 47577
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Current

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 563646,
    "lib": 706618
  },
  "forms": {
    "esm": 35672,
    "lib": 47577
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

@stefhatcher stefhatcher merged commit 243c289 into master Apr 21, 2020
@stefhatcher stefhatcher deleted the stefanie--modal-top-bar branch April 21, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants