update(ErrorMessage,ErrorBoundary): Show error info and error/trace IDs #363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @milesj @stefhatcher @hayes @alecklandgraf
Description
ErrorMessage
no longer shows a Button/Link when provided anerror_id
ortrace_id
. Instead of shows those IDs in plaintext with aCopy
next to it. Button/Links didn't make sense since we'd be showing it to users who might not have access to them.ErrorBoundary
now usesErrorMessage
to show the actual error instead of the hardcodedTripped
component. I've moved a phraselunar.error.featureCrashed
out ofTripped
and intoErrorMessage
as it seemed more useful to me.Tripped
componentMotivation and Context
This is useful for debugging issues.
Testing
Updated existing tests. Tested locally with
yarn sg
.Screenshots
ErrorMessage before:
ErrorMessage after:
ErrorBoundary before:
ErrorBoundary after:
Checklist