Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(ErrorMessage,ErrorBoundary): Show error info and error/trace IDs #363

Merged
merged 3 commits into from
Apr 24, 2020

Conversation

Tgeo
Copy link
Collaborator

@Tgeo Tgeo commented Apr 23, 2020

to: @milesj @stefhatcher @hayes @alecklandgraf

Description

  • ErrorMessage no longer shows a Button/Link when provided an error_id or trace_id. Instead of shows those IDs in plaintext with a Copy next to it. Button/Links didn't make sense since we'd be showing it to users who might not have access to them.
  • ErrorBoundary now uses ErrorMessage to show the actual error instead of the hardcoded Tripped component. I've moved a phrase lunar.error.featureCrashed out of Tripped and into ErrorMessage as it seemed more useful to me.
  • Deleted private Tripped component

Motivation and Context

This is useful for debugging issues.

Testing

Updated existing tests. Tested locally with yarn sg.

Screenshots

ErrorMessage before:

image

ErrorMessage after:

image

ErrorBoundary before:

image

ErrorBoundary after:

image

Checklist

  • My code follows the style guide of this project.
  • I have updated or added documentation accordingly.
  • I have read the CONTRIBUTING document.

@Tgeo Tgeo changed the title Update(ErrorMessage, ErrorBoundary): Show error and trace IDs instead of linking update(ErrorMessage,ErrorBoundary): Show error and trace IDs instead of linking Apr 23, 2020
@Tgeo Tgeo changed the title update(ErrorMessage,ErrorBoundary): Show error and trace IDs instead of linking update(ErrorMessage,ErrorBoundary): Show error info and error/trace IDs Apr 23, 2020
Copy link
Contributor

@milesj milesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Just gotta fix build.

@airbnb-bot
Copy link
Collaborator

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
core -0.1% 550.34 KB 550.69 KB 689.78 KB 690.4 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 563903,
    "lib": 706970
  },
  "forms": {
    "esm": 35672,
    "lib": 47577
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Current

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 563551,
    "lib": 706339
  },
  "forms": {
    "esm": 35672,
    "lib": 47577
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

@Tgeo Tgeo merged commit bf0965a into master Apr 24, 2020
@Tgeo Tgeo deleted the tgeonetta--error-trace-ids branch April 24, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants