new(Card): Adding two props 'noShadow' and 'selected' for Card #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Changes
View raw build statsPrevious (master){
"apollo": {
"esm": 10832,
"lib": 14147
},
"app-shell": {
"esm": 12906,
"lib": 19874
},
"composer": {
"esm": 68247,
"lib": 101805
},
"core": {
"esm": 580573,
"lib": 726065
},
"forms": {
"esm": 37350,
"lib": 49298
},
"icons": {
"esm": 156355,
"lib": 205626
},
"layouts": {
"esm": 15298,
"lib": 20770
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4279,
"lib": 5937
}
}Current{
"apollo": {
"esm": 10832,
"lib": 14147
},
"app-shell": {
"esm": 12906,
"lib": 19874
},
"composer": {
"esm": 68247,
"lib": 101805
},
"core": {
"esm": 580852,
"lib": 726374
},
"forms": {
"esm": 37350,
"lib": 49298
},
"icons": {
"esm": 156355,
"lib": 205626
},
"layouts": {
"esm": 15298,
"lib": 20770
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4279,
"lib": 5937
}
} |
|
2 added in Happo report:
|
|
@williaster @alecklandgraf PTAL when you got a chance. : ) |
williaster
requested changes
Aug 3, 2020
| return ( | ||
| <div | ||
| className={cx( | ||
| !noShadow && styles.card, |
There was a problem hiding this comment.
I think the way you've written this breaks the component. styles.card sets
pattern.box(border/boxShadow/borderRadius)backgroundColoroverflow
and your styles.card_noShadow only applies border and ignores the rest. it seems like we could always apply styles.card, and re-define card_noShadow to only override boxShadow?
williaster
reviewed
Aug 4, 2020
monicapharm
force-pushed
the
mma-add-card-styles
branch
from
de80436 to
818b6ad
Compare
|
@williaster Do you know why the pull request CI failed? looks like it's not related to my change 🤔 |
|
happo has been flaky recently 😞 re-running them. |
|
Re-run the CI a couple of times, finally got them passed 😄 @williaster PTAL |
williaster
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @williaster @alecklandgraf
Description
Add two new props for the
Cardcomponent.noShadowthat hides the shadow of the card.selectedthat shows the border when selected.Motivation and Context
Background:
Some discussions are here https://git.musta.ch/airbnb/solar/issues/978, the design team call out for adding a new variation '
noShadow' for Card to support some features like the wrapper of checkboxes.And in the long run, looks like the Lunar team also consider to refactor
clickable button checkboxesto just being wrapped withcard, so also adding theselectedstate here in this PR.Design: figma
Testing
Local storybook and unit tests.
Screenshots
When there is noShadow:
When selected:
Checklist