Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(ImageViewer): Add dropdownAbove prop #398

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

apiel51
Copy link
Collaborator

@apiel51 apiel51 commented Aug 7, 2020

to: @williaster @alecklandgraf

Description

We have a use case in Torch to place the zoom controls at the bottom of the screen which results in the dropdown menu being cut off. Adding a prop to override this.

Motivation and Context

Above

Testing

Storybook

Screenshots

image

Checklist

  • My code follows the style guide of this project.
  • I have updated or added documentation accordingly.
  • I have read the CONTRIBUTING document.

@airbnb-bot
Copy link
Collaborator

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
core +0.0% 567.33 KB 567.24 KB 709.46 KB 709.35 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 580852,
    "lib": 726374
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Current

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 580946,
    "lib": 726483
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

@apiel51
Copy link
Collaborator Author

apiel51 commented Aug 20, 2020

@alecklandgraf @williaster PTAL 🙏

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay.

lgtm, re-running the happo jobs which timed out

@apiel51
Copy link
Collaborator Author

apiel51 commented Aug 25, 2020

@williaster Looks like CI got canceled, any idea why this is?

@williaster
Copy link
Contributor

there's a fast fail so downstream tasks don't run if upstream ones fail. looks like the upstream ones passed, just restarted the downstream ones 🤞

@williaster williaster merged commit 8aa31dd into master Aug 26, 2020
@williaster williaster deleted the apiel--zoom-dropdownAbove branch August 26, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants