Add possibility to add multiple shadows and shadow spread #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieudutour
requested changes
Jun 3, 2018
| @@ -18,6 +19,11 @@ const propTypes = { | |||
| resizingConstraint: PropTypes.shape({ | |||
| ...ResizingConstraintPropTypes, | |||
| }), | |||
| shadowGroup: PropTypes.arrayOf( | |||
There was a problem hiding this comment.
let's just call it shadows?
| import PropTypes from 'prop-types'; | ||
|
|
||
| module.exports = { | ||
| shadowColor: PropTypes.oneOfType([PropTypes.string, PropTypes.number]), |
There was a problem hiding this comment.
we should add shadowInner to support multiple inner shadows as well
| @@ -2,7 +2,7 @@ | |||
| import type { SJFill, SJPath, SJRect, SJShapeGroupLayer } from '@skpm/sketchapp-json-flow-types'; | |||
| import { makeResizeConstraint } from './hacksForJSONImpl'; | |||
| import { generateID, makeRect } from './models'; | |||
| import type { ResizeConstraints } from '../types'; | |||
| import type { ResizeConstraints, SketchShadowGroup } from '../types'; | |||
| if (props.shadowGroup) { | ||
| const shadows = []; | ||
| props.shadowGroup.map(shadowStyle => | ||
| shadows.push(makeShadow(shadowStyle)) |
There was a problem hiding this comment.
let's push to innerShadows as well if shadowStyle.shadowInner is true
| shadows.push(makeShadow(shadowStyle)) | ||
| ); | ||
| content.style.shadows = shadows; | ||
| } else if (hasAnyDefined(style, SHADOW_STYLES)) { |
There was a problem hiding this comment.
instead of an else if we should probably concatenate the shadow defined in style if there is one
| @@ -73,6 +73,8 @@ export type ViewStyle = { | |||
| shadowOffset: { width: number, height: number }, | |||
| shadowOpacity: number, | |||
| shadowRadius: number, | |||
| shadowSpread: number, | |||
| shadowInner: "innerShadow" | "shadow", | |||
There was a problem hiding this comment.
this should be a boolean.
And we could probably reuse the SketchShadow type as well (type ViewStyle = {...} & SketchShadow)
|
#358 fix conflicts and @mathieudutour requested changes. Thank you @ludwigfrank |
|
fixed in #358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #161 this would add the shadowGroup prop to View, allowing multiple shadows to be added.
P.S. I'm new to working on big projects like this. I would be very grateful for any feedback. Thanks for opening this project to the community.