Remove defaultProps
from Page
component (enables auto-incrementing page name)
#296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The default name prop on the
Page
component provides no value. It in-fact has negative consequences. If we create multiple pages with no specified name, they will all default toPage 1
. If instead we let the name remain undefined, Sketch will create the page using an auto-incremented name (Page 1, Page 2, Page 3, etc...)Solution
Remove the
defaultProps.name
definition :)Implementation Notes
This is a larger concern than just this particular PR, but I don't see where or how I can create tests to confirm functionality that involves Sketch's behavior (in this case, the behavior of
document.addBlankPage
). I was able to manually test this by opening sketch and rendering multiplePage
components without specifying the name.