Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for paragraph spacing #382

Merged
merged 2 commits into from
Sep 20, 2018
Merged

Conversation

lessthanzero
Copy link
Contributor

Added a very basic support for the paragraph spacing. Also checked the creation text styles.
With @adryweber

@mathieudutour
Copy link
Collaborator

paragraphSpacing isn't supported in react-native. What would be the use case of using paragraphSpacing instead of just using 2 Text layers?

@lessthanzero
Copy link
Contributor Author

@mathieudutour we use RSA to generate design components library with reusable text styles where paragraph spacings could be quite handy, so that designer can work with a single stylised text chunk instead of glueing together two layers.

@mathieudutour
Copy link
Collaborator

Ah I see, make sense

@mathieudutour mathieudutour merged commit da83cde into airbnb:master Sep 20, 2018
sml782 added a commit to sml782/react-sketchapp that referenced this pull request Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants