Handle string only errors in RedBox.js #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
petetnt
commented
Apr 29, 2017
| @@ -17,7 +17,7 @@ type StackFrame = { | |||
| functionName?: string, | |||
| source?: string, | |||
| args?: any[], | |||
| evalOrigin?: StackFrame, | |||
| evalOrigin?: StackFrame | |||
There was a problem hiding this comment.
Prettier strips the trailing comma from here 🤔
There was a problem hiding this comment.
Looks like eslint doesn't catch dangling commas in types — cc @ljharb
There was a problem hiding this comment.
It wouldn't; eslint (and the airbnb style guide) doesn't support flow. If you're using Flow, you'd need a separate flow-specific eslint config.
|
Nice work, thanks @petetnt :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #50 by handling
stringonly errors inRedBox.js. If the encountered error is a string, theRedBox.jswill render the error in a generic way as early as possible.In #50 the error was raised by a third party module
chroma.js, which only throws strings in the errors (which is sadly relatively common, I guess).Before:
After:
Signed-off-by: petetnt pete.a.nykanen@gmail.com