Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react 16.3 #246

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Upgrade to react 16.3 #246

merged 1 commit into from
Apr 6, 2021

Conversation

indiesquidge
Copy link
Member

@indiesquidge indiesquidge commented Apr 6, 2021

Follow-up from #240 (comment) to create a breaking change to solidify support and peer dependency requirements on React 16.3+, chiefly to support React.forwardRef for this HOC.

Version 4.2.0 will be the final version to support earlier versions of React.

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending changes (as a semver-major)

package.json Outdated Show resolved Hide resolved
src/withStyles.jsx Outdated Show resolved Hide resolved
src/withStyles.jsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to add testing on react 17, once enzyme has an adapter for it; maybe file a TODO issue for that that links to enzymejs/enzyme#2430 ?

Revert commit 220e2f0 and bump peer deps to fully support React.forwardRef
@indiesquidge indiesquidge force-pushed the upgrade-to-react-16.3 branch from 5eaabee to f4d52a2 Compare April 6, 2021 19:44
@indiesquidge indiesquidge merged commit f4d52a2 into master Apr 6, 2021
@indiesquidge indiesquidge deleted the upgrade-to-react-16.3 branch April 6, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants