Modification Cornucopia

[NickHeiner]

Hi. I recently used ts-migrate, in conjunction with my own codemod runner, to migrate large portions of my codebase to TS. It was fun!

Along the way, I made a series of modifications to make ts-migrate work for my repo. Some of them are likely specific to my idiosyncrasies, but some may be generally applicable. I'll list them here, and you can tell me which, if any, you're interested in. I'll then carve individual PRs for the pieces you want.

Change List

Here's the full set of changes, but it's a bit noisy because some of it is things I'd never recommend merging / it's not cleaned up for you. So I'll also link to individual commits in the list below, but it's not always a 1:1 mapping 🤪 .

• Upgrade from TS 4.2 to TS 4.6
• Reignore: Add ability to specify a custom message for inserted ts-expect-error comments
• Reignore: Add ability to skip the eslint fix step
• Reignore: Add ability to skip the "strip ts-ignore" step
• Rename: Pass back a list of files that were modified. I used this for downstream tooling that would do further processing on those files.
• ts-migrate-server: Fix bug where absolute paths were treated as relative paths
• ts-migrate-server: Return a list of modified files
• Rename: “Improve” JSX detection
• Rename: Don’t rename foo.js to foo.ts if a foo.d.ts already exists.

Anyway, lmk if you're interested in any of this. 😄

Task Tracking

Completed Changes

• TS update to 4.7 – looks like someone got there before me. 😄

[Rudeg]

Hi @NickHeiner ,

Sorry for the delay.

I'm glad that ts-migrate helped you with migration!
Some of those changes would definitely be nice to merge into the ts-migrate.

Those seem like good candidates to be added:

• Upgrade from TS 4.2 to TS 4.6
• Reignore: Add ability to specify a custom message for inserted ts-expect-error comments
• Rename: Pass back a list of files that were modified. I used this for downstream tooling that would do further processing on those files.
• ts-migrate-server: Fix bug where absolute paths were treated as relative paths
• ts-migrate-server: Return a list of modified files

It would probably be better to add a generic ability to skip plugin/plugging instead of custom options for each plugin.

Let me know what you think!

[NickHeiner]

Cool – I'll probably have time to do some of these PRs in a month or so. Or anyone else is welcome to make an attempt in the meantime. 😄

Also, I recently ran into issues that I think are attributable to a stale tsbuildinfo after updating the compilerOptions in tsconfig. This may account for some instances where ts-migrate inserted ts-expect-errors unnecessarily, or failed to insert some that were needed. I don't have a bulletproof repro yet, but it may be safer for ts-migrate to delete tsbuildinfo before building the TS project, to avoid any such risks.

[devinrhode2]

idk if it's just me... but I'd much rather try my luck with @NickHeiner's fork instead of the current master

I took @NickHeiner's fork and carefully rebased it onto latest upstream/master (airbnb/master)

git remote add devinrhode2 git@github.com:devinrhode2/ts-migrate.git
git checkout --track devinrhode2/nth/tvui-modifications-rebased-by-devin

I'm not sure of the BEST way to use it locally... I guess I need to learn a little bit of Lerna.. maybe use yalc

[devinrhode2]

@NickHeiner or anyone, if you have any idea how to use a fork of ts-migrate locally, that would be great :)

It's easy to clone the fork, install deps, run various npm scripts... but I'm not sure how to then use that inside of my company's project... presumably I need to basically npm install ../path/to/project but the tricky part is that ts-migrate uses Lerna, so.. I'm not sure just doing npm install ../path would work

[NickHeiner]

You want to use link for the use-case of pointing one repo to a dep that's another local repo.

I recommend doing:

# in the ts-migrate repo
yarn
yarn build
yarn link

# In the repo you want to use ts-migrate from
yarn link ts-migrate

If your repo is using npm, then maybe npm link will work. But I'm not sure how it works when one project is using npm and the other is using yarn. Maybe you can npm link in both repos.

[NickHeiner]

Happy to help! 😀

…

On Mon, Jun 20, 2022 at 19:34 Devin Rhode ***@***.***> wrote: Our project has a TON of files named just .js, which contain jsx. So turns out I need the patched jsx heuristic. You comment came in JUST in time! — Reply to this email directly, view it on GitHub <#168 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGKTA7Y4OXPVVQEEWKS543VQD5ZPANCNFSM5VPIEVXQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[devinrhode2]

@NickHeiner all those setup steps ran without warnings or errors, but when I finally ran yarn run ts-migrate locally, it was as if ts-migrate was not actually installed.

I did have success using verdaccio instead:

npm install --global verdaccio@6-next
verdaccio

Publish forked package locally:

git clone https://github.com/devinrhode2/ts-migrate.git ts-migrate-devin
cd ts-migrate-devin
git checkout nth/tvui-modifications-rebased-by-devin
yarn install
yarn run bootstrap
yarn run build
npm adduser --registry http://localhost:4873
YARN_REGISTRY=http://localhost:4873 yarn lerna publish

finally:

YARN_REGISTRY=http://localhost:4873 yarn add ts-migrate --dev

[NickHeiner]

Yep, that all makes sense to me! I’ll probably have time to send some PRs for this in a month or so. Or anyone else can feel free to slice chunks out of my PR in the meantime. :)

…

On Fri, May 20, 2022 at 19:23 Sergii Rudenko ***@***.***> wrote: Hi @NickHeiner <https://github.com/NickHeiner> , Sorry for the delay. I'm glad that ts-migrate helped you with migration! Some of those changes would definitely be nice to merge into the ts-migrate. Those seem like good candidates to be added: - Upgrade from TS 4.2 to TS 4.6 <6d038da> - Reignore: Add ability to specify a custom message for inserted ts-expect-error comments <806b8c8> - Rename: Pass back a list of files that were modified <b650943>. I used this for downstream tooling that would do further processing on those files. - ts-migrate-server: Fix bug where absolute paths were treated as relative paths <2d52be0> - ts-migrate-server: Return a list of modified files <2d52be0> It would probably be better to add a generic ability to skip plugin/plugging instead of custom options for each plugin. Let me know what you think! — Reply to this email directly, view it on GitHub <#168 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGKTA2WTR5JYEQIR45QKXLVLANFPANCNFSM5VPIEVXQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>