Use NodeFactory to create and update nodes #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most ts.create* and ts.update* functions are deprecated as of TypeScript 4.0. The current plan is to emit noiser and noisier warnings with each version until the deprecated functions are removed in 4.3. See this pull request for more details: microsoft/TypeScript#35282 Some method signatures and names have changed slightly. The easy way to update is to use the global ts.factory object. TypeScript transformations also have access to a NodeFactory in their transformation contexts. Note that we still use the deprecate getMutableClone function because its replacement is not included in the TypeScript declarations. See microsoft/TypeScript#40507
edsrzf
commented
Oct 24, 2020
| sourceText: string, | ||
| options: Options, | ||
| ): string { | ||
| const sourceFile = ts.createSourceFile(fileName, sourceText, ts.ScriptTarget.Latest, true); |
There was a problem hiding this comment.
I also noticed we were creating a new source file here when we could have passed through the one given to run, and couldn't see a reason for doing that.
| sourceText: string, | ||
| force = false, | ||
| ) { | ||
| const sourceFile = ts.createSourceFile(fileName, sourceText, ts.ScriptTarget.Latest, true); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most
ts.create*andts.update*functions are deprecated as of TypeScript 4.0. The current plan is to emit noisier and noisier warnings with each version until the deprecated functions are removed in 4.3.See this pull request for more details: microsoft/TypeScript#35282
Some method signatures and names have changed slightly.
The easy way to update is to use the global
ts.factoryobject. TypeScript transformations also have access to aNodeFactoryin their transformation contexts.Note that we still use the deprecate
getMutableClonefunction because its replacement is not included in the TypeScript declarations. See microsoft/TypeScript#40507I found uses of deprecated functions by searching code for the terms
ts.createandts.update. This turned up some false positives, such as calls tots.createPrinter, which I ignored.