Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] document api of all packages #9

Closed
hshoff opened this issue May 8, 2017 · 12 comments
Closed

[docs] document api of all packages #9

hshoff opened this issue May 8, 2017 · 12 comments
Milestone

Comments

@hshoff
Copy link
Member

hshoff commented May 8, 2017

No description provided.

@hshoff hshoff added this to the v1 milestone May 8, 2017
@Flaque
Copy link
Contributor

Flaque commented May 9, 2017

Hey, this might be a stupid question, but where's the repo for the docs?

@hshoff
Copy link
Member Author

hshoff commented May 9, 2017

Great question. My current plan is to add docs to each packages/**/Readme.md then write a script that builds those to a new dir called docs/ at the vx repo root. Open to suggestions for alternative solutions!

@Flaque
Copy link
Contributor

Flaque commented May 13, 2017

I looked into react-docgen a bit for linking docs to code. But react-docgen assumes a class structure for it's objects and doesn't really work all that well with the existing code. It might be a future thing, but I'm just gonna write docs in the Readme's for the moment.

Flaque added a commit to Flaque/vx that referenced this issue May 13, 2017
hshoff added a commit that referenced this issue May 13, 2017
Add docs for `@vx/point`. Issue #9
Flaque added a commit to Flaque/vx that referenced this issue May 15, 2017
Flaque added a commit to Flaque/vx that referenced this issue May 15, 2017
Flaque added a commit to Flaque/vx that referenced this issue May 16, 2017
@Flaque
Copy link
Contributor

Flaque commented May 19, 2017

Is brush "stable"-ish right now? There's no longer a gallery version of it. Should I just hold off on writing the docs on it for now?

Flaque added a commit to Flaque/vx that referenced this issue May 20, 2017
Flaque added a commit to Flaque/vx that referenced this issue May 20, 2017
@trainorpj
Copy link
Contributor

Do you need help writing some of the documentation? I could submit a PR for the boxplots docs, if nobody has that action.

I've been watching this project for a while, and I like it a lot. I'm interested in helping out, if you'll have me!

@Flaque
Copy link
Contributor

Flaque commented Jul 15, 2017

Do it! :D

Let me know it you need any help ❤️

@williaster
Copy link
Collaborator

🙈 didn't mean to close the entire issue

@williaster williaster reopened this Jul 17, 2017
@kandros
Copy link
Contributor

kandros commented Aug 16, 2017

These are the packages with missing documentation

  • brush
  • clip-path
  • brush
  • drag
  • event
  • hierarchy
  • responsive
  • tooltip
  • zoom

@trainorpj
Copy link
Contributor

I wrote the docs for the boxplot component, and I'm happy to contribute to other utilities/components

(I was a bit swamped before, but I have some time now)

@trainorpj
Copy link
Contributor

I just hacked together a little site we can use to keep track of progress on the docs:

https://trainorpj.github.io/vx-docs-progress/

I figured there are so many packages/components it'd be nice to keep track of things at a high level.

Link to the repo. Feel free to make changes. I used d3 but didn't use vx... 😬

@hshoff
Copy link
Member Author

hshoff commented Sep 5, 2017

Very helpful, thank you @trainorpj! I'm hoping for all green by v1

@hshoff
Copy link
Member Author

hshoff commented Jan 28, 2019

This should be fixed in: #399

Need to add descriptions, but at least api doc generation is automated now.

@hshoff hshoff closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants