Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo/barstack): improve Tooltip positioning logic #1018

Merged
merged 2 commits into from
Jan 12, 2021

Conversation

williaster
Copy link
Collaborator

📝 Documentation

🐛 Bug Fix

This closes #1016 and improves the logic for tooltip positioning in the /barstack demo. That example was refactored to use TooltipInPortal when it was added, and the logic wasn't as robust as it should have been.

tl;dr left/top should have been in SVG coordinates, but top was in viewport coordinates. If anything is rendered above the chart this breaks (as shown in the issue, reproduced with the yellow box below).

Before

After

@hshoff
cc @wisyr

@coveralls
Copy link

coveralls commented Jan 12, 2021

Pull Request Test Coverage Report for Build 479261526

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.336%

Totals Coverage Status
Change from base Build 478565296: 0.0%
Covered Lines: 1737
Relevant Lines: 2699

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 28, 2024

Pull Request Test Coverage Report for Build 479261526

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.336%

Totals Coverage Status
Change from base Build 478565296: 0.0%
Covered Lines: 1737
Relevant Lines: 2699

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BarStack] Weird behavior of tooltip when chart is preceded with html element.
3 participants