Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert breaking "deps(scale): bump d3-interpolate and d3-scale" #1619

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Revert breaking "deps(scale): bump d3-interpolate and d3-scale" #1619

merged 1 commit into from
Jan 3, 2023

Conversation

williaster
Copy link
Collaborator

Reverts #1578

So save folks some pain with the implications of the ESM-only d3 dependencies from this change, I'm going to

  • revert this PR
  • release a new minor version with the old dependencies
  • re-merge this PR
  • release a new major version with the new dependencies so people can opt into the ESM changes

will ultimately fix #1613
cc @jreyes33 @rj-david

@williaster williaster mentioned this pull request Jan 3, 2023
Merged
@williaster williaster merged commit 75ba46e into master Jan 3, 2023
williaster added a commit that referenced this pull request Jan 3, 2023
@williaster
Revert "Revert "deps(scale): bump d3-interpolate and d3-scale (#1578
71ff3e8 
)" (#1619)"

This reverts commit 75ba46e.
@williaster williaster mentioned this pull request Jan 3, 2023
Merged
4 tasks
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

🎉 This PR is included in version v2.18.0 of the packages modified 🎉

@williaster williaster deleted the revert-1578-master branch January 4, 2023 20:57
williaster added a commit that referenced this pull request Jan 6, 2023
@williaster
Revert "Revert "deps(scale): bump d3-interpolate and d3-scale (#1578
7d4c243 
)" (#1619)"

This reverts commit 75ba46e.
williaster added a commit that referenced this pull request Jan 6, 2023
@williaster
Revert "Revert breaking "deps(scale): bump d3-interpolate and `d3-s…
7e2e2a0 
…cale`"" (#1621)

* Revert "Revert "deps(scale): bump `d3-interpolate` and `d3-scale` (#1578)" (#1619)"

This reverts commit 75ba46e.

* deps: update yarn.lock

* deps: resolve @babel/parser to ^7.15.3 to fix jest tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐛 bug minor-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking change with ESM requirement for 2.17.0 due to npm audit fix
1 participant
@williaster