-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: Refactor to nimbus #484
Merged
Merged
Changes from all commits
Commits
Show all changes
114 commits
Select commit
Hold shift + click to select a range
7ec6b7d
add @irbnb/nimbus, add dotfiles, remove config files
c3edc41
deps: remove unneeded config deps
db6c6e7
v1.17.3
3923715
update lerna.json, package.json
129f0ef
deps(vx-annotation): remove unneeded build config in package.json
9810058
more root config changes
651739a
remove react/jsx-filename-extension override
b411ed3
build(vx-annotation): files to .jsx, remove more unneeded config, lin…
e8fc435
build(root, vx-annotation): Remove unused scripts
f618ba3
prettier(root): run on *.md
0d433f8
build(vx-annotation): remove devDependencies, update package files to…
a3a4945
build(vx-axis): remove unneeded config
7b86252
build(vx-axis): .js => .jsx where relevant
5e015cf
lint(vx-axis)
2e1c70c
build(vx-text): remove unneeded config
4cba8d0
lint(vx-text): lint and *.js => *.jsx
b7d5bab
build(vx-scale): remove unneeded config
d3263fe
lint(vx-scale)
d64d2df
root: remove unneeded -- in scripts
5b3a432
build(vx-shape): remove uneeded config
6a047d3
lint(vx-shape): lots of fixes
fd4ae24
build(vx-group): remove unneeded config
8bcf1ef
lint(vx-group): lint and *.js => *.jsx
df7b2fa
build(vx-point): remove uneeded config
303ee8b
lint(vx-point)
49aad43
build(vx-curve): remove unneeded config
bc1e38d
lint(vx-curve)
a9fb963
build(vx-chord): remove unneeded config
2f57788
lint(vx-chord): lint and *.js => *.jsx
792ebd8
build(vx-bounds): remove unneeded config
3f6bc6f
lint(vx-bounds)
27d2b2a
build(vx-boxplot): remove unneeded config
a6f0acf
lint(vx-boxplot)
a20b369
build(vx-brush): remove unneeded config
c746edc
lint(vx-brush)
57dbfa0
build(vx-legend): remove unneeded config
793da7f
lint(vx-legend)
8e72971
fix(vx-axis): fix vx-scale paths in tests
e481c99
build(vx-clip-path): remove unneeded config
5e03750
lint(vx-clip-path)
4be9902
fix(vx-boxplot): fix vx-scale paths in tests
ee2c04a
build(vx-pattern): remove unneeded config
7b98c52
lint(vx-patterns)
3226829
build(vx-responsive): remove unneeded config
4976a78
lint(vx-responsive)
3ba997d
build(vx-voronoi): remove unneeded config
64de3d5
lint(vx-voronoi)
b37055c
build(vx-marker): remove unneeded config
2e70421
lint(vx-marker)
1e69e7a
build(vx-network): remove unneeded config
90ae564
lint(vx-network)
b6b1ec8
build(vx-zoom): remove unneeded config
cbd8a01
lint(vx-zoom)
953e00f
build(vx-drag): remove unneeded config
9ec2a01
lint(vx-drag)
7dd16fc
build(vx-grid): remove unneeded config
e411f62
lint(vx-grid)
c2739f2
build(vx-event): remove unneeded config
770b495
build(vx-event): remove unneeded config 2
dc76ea3
lint(vx-event)
f93299a
build(vx-geo): remove unneeded config
a9904dd
lint(vx-geo)
391d955
deps(vx-geo): add back topojson-client devDep
8c8a507
build(vx-glyph): remove unneeded config
38cd3b9
lint(vx-glyph)
68fb7c8
build(vx-gradient): remove unneeded config
ced3239
lint(vx-gradient): lint and fix gross tests
18b9173
build(vx-mock-data): remove unneeded config
cef422e
lint(vx-mock-data)
c437e16
build(vx-heatmap): remove unneeded config
42b7ab0
lint(vx-heatmap)
8951a60
build(vx-tooltip): remove unneeded config
502853d
lint(vx-tooltip)
4dbf7f7
build(vx-hierarchy): remove unneeded config
654b3a6
lint(vx-hierarchy)
cc8ab1c
build(vx-threshold): remove unneeded config
55b8912
lint(vx-threshold)
ea840f3
build(vx-stats): remove unneeded config
cf4b742
lint(vx-stats)
e60c0a8
build(vx-vx): remove unneeded config
5bd941a
fix(vx-shape): *.js => *.jsx, fix tests
3d29612
lint: no-console: off
ae5f122
fix(vx-text): allow any child
1e21200
fix(vx-text): allow any child
2cf024e
fix(vx-pattern): fix Hexagons tests
be3c9b4
prettier(vx-shape): make tests prettier
6c0f1b5
root: remove core-js dep, update husky file signature
f2f13b6
prettier(vx-pattern)
79c3b2a
docs: update docs
13ef549
lint(scripts/docs/index)
98283d6
deps: use open-source nimbus #blessed
ddf598d
fix(vx-demo): remove unneeded dev deps and scripts
2b3303e
build: don't build demo
362b653
scripts: add build-one script
731d5d3
fix(vx-event): fix error when node is passed
3ca34f4
fix(vx-shape): fix Polygon point generator
36cbea7
dev-deps(root): remove more unneeded dev deps
93347d1
travis: use yarn, use matrix for test + lint
4dd008b
root: add npmrc file
da3237d
nimbus: update srcFolder to match vx-demo files
bf63a18
lint(vx-demo)
834f612
vx-demo: upgrade to next@9
ca7d001
vx-demo: move everything into src/ for nimbus
eff4f08
nimbus: remove srcFolder override
54dba62
dev: remove dev-deps included with nimbus, turn on next
be03a72
scripts(root): remove bootstrap script
6365317
more linting for next setting
504029c
Merge branch 'master' of github.com:hshoff/vx into chris--nimbus
6b1dfe5
lint(camelcase): ignore UNSAFE_* lifecycle methods
256cb51
fix: fix root clean script
279a13a
deps(nimbus): 2.0.0
4febeb5
dev(dotfiles): update ignore files with tsconfig.eslint.json
8f45d5f
lint(vx-curve): wrap test in describe block
f56fc69
prettier(vx-demo): format css
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,8 @@ | ||
.DS_Store | ||
node_modules | ||
build | ||
dist | ||
test | ||
rollup.config.js | ||
vx-demo | ||
scripts | ||
bundle.js | ||
test/tmp | ||
*.log | ||
*.cache | ||
/.eslintcache | ||
.next | ||
coverage | ||
package-lock.json | ||
npm-shrinkwrap.json | ||
yarn.lock | ||
coverage/ | ||
node_modules/ | ||
public/ | ||
esm/ | ||
lib/ | ||
tmp/ | ||
dist/ | ||
*.d.ts |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,47 @@ | ||
.DS_Store | ||
node_modules | ||
build | ||
dist | ||
bundle.js | ||
test/tmp | ||
*.DS_Store | ||
|
||
# Logs | ||
logs/ | ||
*.log | ||
*.cache | ||
/.eslintcache | ||
.next | ||
coverage | ||
package-lock.json | ||
|
||
# Cache | ||
.bundle/ | ||
.eslintcache/ | ||
.happo/ | ||
.idea/ | ||
.next/ | ||
.npm/ | ||
.vscode/ | ||
|
||
# Directories | ||
build/ | ||
coverage/ | ||
dist/ | ||
esm/ | ||
lib/ | ||
public/ | ||
node_modules/ | ||
tmp/ | ||
|
||
# Custom | ||
*.min.js | ||
*.map | ||
|
||
# Configs (provided by Nimbus) | ||
.babelrc | ||
.eslintignore | ||
.eslintrc.js | ||
.flowconfig | ||
.prettierignore | ||
babel.config.js | ||
jest.config.js | ||
prettier.config.js | ||
tsconfig.eslint.json | ||
tsconfig.json | ||
webpack.config.js | ||
|
||
# Lock files, libs should not have lock files | ||
npm-shrinkwrap.json | ||
yarn.lock | ||
package-lock.json | ||
yarn.lock |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
.DS_Store | ||
|
||
# Logs | ||
logs/ | ||
*.log | ||
|
||
# Cache | ||
.eslintcache/ | ||
.idea/ | ||
.npm/ | ||
.vscode/ | ||
.yarnclean | ||
|
||
# Directories | ||
build/ | ||
coverage/ | ||
dist/ | ||
public/ | ||
node_modules/ | ||
tmp/ | ||
|
||
# Custom | ||
*.min.js | ||
*.map | ||
|
||
# Configs | ||
.babelrc | ||
.dockerignore | ||
.eslintignore | ||
.eslintrc.js | ||
.flowconfig | ||
.gitattributes | ||
.gitignore | ||
.npmrc | ||
.prettierignore | ||
.yarnc | ||
babel.config.js | ||
dangerfile.ts | ||
jest.config.js | ||
prettier.config.js | ||
tsconfig.eslint.json | ||
tsconfig.json | ||
webpack.config.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
package-lock=false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,16 @@ | ||
.DS_Store | ||
node_modules | ||
build | ||
bundle.js | ||
test/tmp | ||
*.log | ||
*.cache | ||
/.eslintcache | ||
.next | ||
coverage | ||
package-lock.json | ||
coverage/ | ||
node_modules/ | ||
public/ | ||
esm/ | ||
lib/ | ||
tmp/ | ||
dist/ | ||
*.d.ts | ||
lerna.json | ||
npm-shrinkwrap.json | ||
yarn.lock | ||
package.json | ||
package-lock.json | ||
tsconfig.json | ||
tsconfig.eslint.json | ||
tsconfig.options.json | ||
CHANGELOG.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,22 @@ | ||
git: | ||
depth: 10 | ||
language: node_js | ||
node_js: | ||
- "8" | ||
node_js: '12' | ||
before_install: | ||
- curl -o- -L https://yarnpkg.com/install.sh | bash | ||
- export PATH=$HOME/.yarn/bin:$PATH | ||
install: | ||
- yarn install --ignore-engines | ||
before_script: | ||
- yarn run build | ||
matrix: | ||
fast_finish: true | ||
jobs: | ||
include: | ||
- name: Test | ||
script: yarn run jest -w 4 | ||
- name: Lint | ||
script: yarn run lint | ||
cache: | ||
directories: | ||
- node_modules | ||
script: travis_wait 30 npm test | ||
after_script: "cat ./coverage/lcov.info | ./node_modules/.bin/coveralls" | ||
yarn: true | ||
after_script: 'cat ./coverage/lcov.info | ./node_modules/.bin/coveralls' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NPM/Yarn doesn't use them when installing packages. They are meant for developers/contributors or the project though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, Jordan mentioned once that having them can hide bugs/problems in development because developers will be locked into specific versions which consumers might not have on a fresh install.