perf(vx-tooltip): use useCallback in useTooltip #668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
When using
useTooltip
introduced in #631 I noticed that passingshowTooltip
orhideTooltip
to a child component causes unnecessary and potentially expensive render cascades / child updates even thoughtooltipLeft
,tooltipTop
, ortooltipData
didn't change.This should be fixable by using the
useCallback
hook, where the callbacks are not instantiated each render, and thusPureComponent
s orReact.memo
ized components should not update unlesstooltipLeft
,tooltipTop
, ortooltipData
update.@kristw @hshoff
cc @ptmx