new(event): support FocusEvents in localPoint #956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This adds support for
FocusEvent
s to@visx/event
'slocalPoint
and adds corresponding tests. This is needed to enable tab-able / focusable tooltips inXYChart
(coming in another PR).Implementation-wise, since
FocusEvent
s do not have aclientX/Y
likeMouseEvent
s, I think it makes sense to have the location of the focus event be the center of theevent
target
's bounding client rect but am open to other thoughts.@kristw @hshoff