Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(event): support FocusEvents in localPoint #956

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

williaster
Copy link
Collaborator

🚀 Enhancements

This adds support for FocusEvents to @visx/event's localPoint and adds corresponding tests. This is needed to enable tab-able / focusable tooltips in XYChart (coming in another PR).

Implementation-wise, since FocusEvents do not have a clientX/Y like MouseEvents, I think it makes sense to have the location of the focus event be the center of the event target's bounding client rect but am open to other thoughts.

@kristw @hshoff

@coveralls
Copy link

Pull Request Test Coverage Report for Build 399280339

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 61.446%

Totals Coverage Status
Change from base Build 399258596: 0.07%
Covered Lines: 1718
Relevant Lines: 2627

💛 - Coveralls

@williaster williaster added this to the 1.3.0 milestone Dec 3, 2020
@williaster williaster merged commit 9861417 into master Dec 4, 2020
@williaster williaster deleted the chris--event-focusevent branch December 4, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants