Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xychart): PointerEvent fixes #957

Merged
merged 4 commits into from
Dec 3, 2020

Conversation

williaster
Copy link
Collaborator

🐛 Bug Fix

This fixes a couple of issues with PointerEvents in @visx/xychart:

  • *Series subscribe to events from EventProvider, but when sources were added there was a mismatch between the emitter source <> handler source, so handlers were not being invoked.

  • TooltipProvider had an issue where hideTooltip was debounced, which meant a call sequence of showTooltip => hideTooltip => showTooltip could result in the debounced hideTooltip call being invoked after the showTooltip call and closing the tooltip. This was fixed by canceling the debounced call in the showTooltip handler.

@kristw @hshoff

@coveralls
Copy link

coveralls commented Dec 3, 2020

Pull Request Test Coverage Report for Build 399422746

  • 9 of 13 (69.23%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 61.379%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/visx-xychart/src/providers/TooltipProvider.tsx 3 7 42.86%
Totals Coverage Status
Change from base Build 399258596: 0.007%
Covered Lines: 1720
Relevant Lines: 2633

💛 - Coveralls

@williaster williaster merged commit aa1dcae into master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants