Convert historian test to jest. #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See jestjs/jest#2071 - you need to polyfil fetch / XHR etc |
anmic
force-pushed
the
fix/test
branch
2 times, most recently
from
c590f5a to
0ba8331
Compare
|
Fixed test. |
vmihailenco
reviewed
Jul 21, 2019
package.json
Outdated
| @@ -30,6 +30,7 @@ | |||
| "babel-plugin-transform-define": "^1.3.1", | |||
| "chai": "4.2.0", | |||
| "imports-loader": "0.8.0", | |||
| "isomorphic-fetch": "^2.2.1", | |||
There was a problem hiding this comment.
remove and use cross-fetch that is already a dependency
anmic
force-pushed
the
fix/test
branch
2 times, most recently
from
82d1c34 to
b3a81c2
Compare
|
Removed 'cross-fetch' package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.