Allow passing DLL paths (fix #1) #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this PR adds the arguments with default values that mirror the previous definition, so this change does not modify the way existing applications instatiate a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two parameters to
ReplayEngine::ReplayEngine(), which represent the path to theTTDReplay.dllandTTDReplayCPU.dlllibraries. This way, we can load the libraries even if they are not in the same directory as the executable using the bindings.This PR also explicitly loads
TTDReplayCPU.dllwhile setting up the engine. Even if we don't directly use it,TTDReplay.dllrequires it to be loaded to function.