Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secrets support #1

Closed
aaronsteers opened this issue Feb 4, 2024 · 2 comments
Closed

Add secrets support #1

aaronsteers opened this issue Feb 4, 2024 · 2 comments

Comments

@aaronsteers
Copy link
Contributor

aaronsteers commented Feb 4, 2024

This has two phases:

Phase I. Add get_secret() support.

This allows retrieving from env vars or secret managers.

Phase 2. Auto-detect and inject

In this phase, presumably we'd be able to auto-inject secrets if they match a specific naming convention that aligns with the source name and setting name.

Tech Spec here:

https://docs.google.com/document/d/1rqoRuGRDvSYX8TmtxvpJv-XJgzfN46fLYtuMymz-QE8/edit#heading=h.c4ztxwwo0ign

@aaronsteers
Copy link
Contributor Author

First phase (get_secret()) has shipped:

Second phase (auto-detect and inject) has a proposal in the Tech Spec here:

@aaronsteers
Copy link
Contributor Author

Closing phase 1 of this, and will open this as a separate issue:

Phase 2. Auto-detect and inject

In this phase, presumably we'd be able to auto-inject secrets if they match a specific naming convention that aligns with the source name and setting name.

Tech Spec here:

https://docs.google.com/document/d/1rqoRuGRDvSYX8TmtxvpJv-XJgzfN46fLYtuMymz-QE8/edit#heading=h.c4ztxwwo0ign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant