-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AirbyteLib: Add basic secrets management #34822
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality looks good to me, but the "prompt" source for secrets is incompatible with the live view - like with the normal system prompt, the message to enter the secret flashes shortly, then disappears.
#34782 helps as long as you are in a REPL, but in case you run a python script via python my_script.py
, the problem still persists.
Do you plan to implement the auto-loading functionality as described in the tech spec in a follow-up PR?
@flash1293 - Thanks for this review. Re:
Yes. This increment was previously unplanned, but added based on some observations of usage from early testers, and can be incrementally expanded to auto-pull into a setting 'slot' based on name convention. |
This adds a new
get_secret()
option which retrieves from the following sources, in priority order:This approach allows the same code to run identically, even if the secrets are provided in different ways. For instance, in Colab, a secret might be automatically detected and imported, whereas running locally, the same code will import from an environment variable or otherwise will prompt a user in a masked prompt.
Example from the new
run_github.py
example script: