Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improve progress updates, including list of streams finalized #147

Merged
merged 9 commits into from
Mar 28, 2024

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Mar 27, 2024

A small update. This brings back the print of processed stream names.

For example:

                                                                             Read Progress                                                                              

Started reading at 23:31:01.                                                                                                                                            

Read 20,100 records over 2 seconds (10,050.0 records / second).                                                                                                         

Wrote 20,100 records over 3 batches.                                                                                                                                    

Finished reading at 23:31:03.                                                                                                                                           

Started finalizing streams at 23:31:03.                                                                                                                                 

Finalized 3 batches over 8 seconds.                                                                                                                                     

Completed 3 out of 3 streams:                                                                                                                                           

 • purchases                                                                                                                                                            
 • products                                                                                                                                                             
 • users                                                                                                                                                                

Completed writing at 23:31:12. Total time elapsed: 11 seconds 

Previously was missing this block:

Completed 3 out of 3 streams:                                                                                                                                           

 • purchases                                                                                                                                                            
 • products                                                                                                                                                             
 • users                                                                                                                                                                

Copy link
Contributor

@bindipankhudi bindipankhudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@aaronsteers aaronsteers merged commit 2e28882 into main Mar 28, 2024
15 checks passed
@aaronsteers aaronsteers deleted the aj/fix/issue-128/incorrect-0-records-progress branch March 28, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Progress prints lost their end-of-sync summary (the list of stream names)
2 participants