Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Configure warnings as errors in pytest #245

Merged
merged 31 commits into from
May 22, 2024

Conversation

aaronsteers
Copy link
Contributor

We haven't done any hygeine for warnings, and over time a large number of these have accumulated. When users see these, they can cause confusion - and worse, sometimes they are signs of real issues that need to be addressed.

This PR does a few things:

  • Make warnings raise errors in PyTest.
  • Add execptions to pyproject.toml for any errors we do expect.
  • Update specific packages in pyproject.toml which are generating deprecation warnings.

@aaronsteers aaronsteers marked this pull request as draft May 17, 2024 18:12
@aaronsteers
Copy link
Contributor Author

@bindipankhudi - FYI, this is a draft for now, but I hope to finish today. This came up when researching a user-facing issue.

@aaronsteers aaronsteers marked this pull request as ready for review May 21, 2024 19:12
@aaronsteers
Copy link
Contributor Author

aaronsteers commented May 22, 2024

/poetry-lock

poetry lock job started... Check job output.

poetry lock applied successfully.

octavia-squidington-iii and others added 3 commits May 22, 2024 02:48
@aaronsteers aaronsteers enabled auto-merge (squash) May 22, 2024 03:08
@aaronsteers aaronsteers disabled auto-merge May 22, 2024 03:23
@aaronsteers aaronsteers merged commit bd8ee6d into main May 22, 2024
15 checks passed
@aaronsteers aaronsteers deleted the aj/chore/warnings-as-errors-in-pytest branch May 22, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant