-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add "Destinations 1.0" handling to PyAirbyte: sync IDs, generation IDs, and stream success statuses #330
Fix: Add "Destinations 1.0" handling to PyAirbyte: sync IDs, generation IDs, and stream success statuses #330
Conversation
WalkthroughWalkthroughThe recent updates introduce a new script, Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
airbyte/_future_cdk/catalog_providers.py (1)
51-66
: Validation logic encapsulated well.The
validate_catalog
method effectively ensures necessary fields are initialized, enhancing robustness.Consider updating the docstring to reflect the return type change:
- """Validate the catalog to ensure it is valid. + """Validate the catalog to ensure it is valid and return the validated catalog.
Logging here for visibility: I resolved the three missing catalog properties and then received this issue due to the source not emitting an explicit
Addressing now... |
Resolves #329
So far, this PR only gives a script to repro the issue. See #329 and airbytehq/airbyte#43417 for more info.
Summary by CodeRabbit
New Features
Bug Fixes